Repository navigation
ci: Check bundle size increases per PR - #24737
Open
nicohrubec wants to merge 15 commits into
Open
nicohrubec wants to merge 15 commits into
nicohrubec wants to merge 15 commits into
Conversation
![semgrep-code-getsentry[bot]](https://avatars.githubusercontent.com/in/1153895?s=60&v=4){kind=small}
nicohrubec
force-pushed
the
feat/per-pr-bundle-size-check
branch
from
September 25, 2026 11:50
93485e5 to
cf9b39e
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8900460. Configure here.
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
nicohrubec
added
Accept Bundlesize Increase
and removed
Accept Bundlesize Increase
labels
nicohrubec
marked this pull request as ready for review
September 26, 2026 09:11
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
|
👋 @Lms24, @chargome, @andreiborza — Please review this PR when you get a chance! |
Lms24
reviewed
Oct 2, 2026
Member
There was a problem hiding this comment.
Thanks for making this change! I was thinking a bit about if we should explicitly always compare against the base commit where we branched off. But this has a few drawbacks as well:
- the absolute numbers don't reflect the current state on
develop, especially when a PR gets older, until the PR is rebased to latestdevelop - we can't guarantee that we have a base commit size artifact, especially not if we work with stacks. So we need a fallback logic to build that base commit and run size check and upload those results. A lot of work.
So I think we can leave it at comparing against the latest base branch, but this can skew if there are other changes pushed to develop around the same time of opening the PR or pushing new commits onto the PR branch. We should be able to detect this and also include it in the comment.
Something like
## size-limit report 📦
Compared: 8f3c2a1 (your PR merged into develop @ 41be9d0)
Against: 41be9d0 (develop) · base run #18234
✅ Baseline matches: this diff contains only this PR's changes.
| Path | Size | % Change | Change |
| ... | ... | ... | ... |
## size-limit report 📦
Compared: 8f3c2a1 (your PR merged into develop @ 41be9d0)
Against: 9d07e55 (develop) · base run #18229
⚠️ Baseline mismatch: 2 develop commits are not in the baseline
(compare 9d07e55...41be9d0), so their size changes are counted here.
re-run once develop's build for 41be9d0 finishes.
| Path | Size | % Change | Change |
| ... | ... | ... | ... |
For stacks, I think comparing all the PRs in the stack against the baseline is fine. no need to have a per-stack-PR diff.
WDYT?
Contributor
|
👋 @chargome, @andreiborza — Please review this PR when you get a chance! |
3 similar comments
Contributor
|
👋 @chargome, @andreiborza — Please review this PR when you get a chance! |
Contributor
|
👋 @chargome, @andreiborza — Please review this PR when you get a chance! |
Contributor
|
👋 @chargome, @andreiborza — Please review this PR when you get a chance! |
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
nicohrubec
force-pushed
the
feat/per-pr-bundle-size-check
branch
from
October 19, 2026 09:56
6932272 to
ce77293
Compare
Co-Authored-By: GPT-6 <codex@openai.com>
Contributor
size-limit report 📦Compared: 7fa396e (PR test merge using develop at 312818c) Against: 312818c (develop) · base run #62509 ✅ Baseline matches: this diff contains only this PR's changes.
|
Member
Author
|
@Lms24 good idea! finally got around to updating this today. report now shows what we compare against as suggested, should hopefully help to prevent some confusion |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept Bundlesize Increase. If present, it passes without measuring again.Also removing the old absolute size limits and the weekly size limit update workflow, since these are no longer needed now.
Fixes #21813