Skip to content

fix(deno): Enable sessions for HTTP requests - #23313

Draft
AG0708 wants to merge 1 commit into
getsentry:developfrom
AG0708:codex/22888-deno-http-sessions
Draft

fix(deno): Enable sessions for HTTP requests#23313
AG0708 wants to merge 1 commit into
getsentry:developfrom
AG0708:codex/22888-deno-http-sessions

Conversation

@AG0708

@AG0708 AG0708 commented Aug 11, 2026

Copy link
Copy Markdown

Deno's node:http server integration disabled release-health sessions even
though the shared HTTP instrumentation enables them by default. Keeping the
shared default aligns Deno with the other server runtimes and restores session
aggregates for incoming requests when a release is configured.

Root cause

The Deno integration passed sessions: false when it subscribed to shared HTTP
server instrumentation. There is no Deno-specific duplicate instrumentation
that requires that override.

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • Link an issue if there is one related to your pull request.

Fixes #22888

@AG0708
AG0708 marked this pull request as ready for review August 12, 2026 01:15
@AG0708
AG0708 requested a review from a team as a code owner August 12, 2026 01:15
@AG0708
AG0708 requested review from JPeer264 and mydea and removed request for a team August 12, 2026 01:15
@AG0708
AG0708 marked this pull request as draft August 12, 2026 07:54
@JPeer264

Copy link
Copy Markdown
Member

Hey @AG0708 thanks for your contribution. May I ask if there is an existing issue for this?

But I see that the JSDoc actually says that the default is true.

@AG0708

AG0708 commented Aug 14, 2026

Copy link
Copy Markdown
Author

Yes—this addresses #22888, which reports that the Deno HTTP integration hard-codes sessions: false despite the shared instrumentation default. The PR body also includes Fixes #22888.

Deno disabled release-health sessions for incoming node:http requests even though the shared HTTP instrumentation defaults them on. Preserve the shared default and cover it with a real request regression test.

Co-Authored-By: OpenAI Codex <codex@openai.com>
Signed-off-by: Abhinav Gorrepati <gorrepatiabhinav1@gmail.com>
@AG0708
AG0708 force-pushed the codex/22888-deno-http-sessions branch from 9eb32ec to 71f66dc Compare August 14, 2026 19:42
@AG0708

AG0708 commented Aug 14, 2026

Copy link
Copy Markdown
Author

I rebased this branch onto current develop (71f66dc4), which includes #23391, the upstream pin for the LangChain ESM export failure seen in all five red Node integration jobs. Those failures were in the untouched tracing/langchain/v1 suite; the Deno-focused package tests, transpile, type builds, lint, and formatting had passed before the rebase. The refreshed CI run should now exercise this patch with that upstream dependency fix included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deno: http integration hard-codes sessions: false

2 participants