feat: add noop client implementation - #1365
Open
giortzisg wants to merge 1 commit into
Open
Conversation
giortzisg
marked this pull request as ready for review
July 20, 2026 11:24
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
sl0thentr0py
approved these changes
Jul 23, 2026
giortzisg
force-pushed
the
scopes/noop-client
branch
from
July 23, 2026 08:45
4337b6c to
415d82c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 415d82c. Configure here.
| // NewClient creates and returns a Client configured using ClientOptions. | ||
| func NewClient(options ClientOptions) (Client, error) { | ||
| return newClient(options) | ||
| } |
There was a problem hiding this comment.
Typed-nil Client on NewClient error
Medium Severity
NewClient returns (Client, error) by directly forwarding newClient, which returns a nil *defaultClient on failure. That produces a non-nil interface holding a typed nil, so client == nil is false while method calls panic. normalizeClient already guards this for hubs, but the public constructor still exposes it.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 415d82c. Configure here.
giortzisg
force-pushed
the
scopes/noop-client
branch
from
July 30, 2026 20:45
415d82c to
18b7a4a
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds the Client interface and noop and default client implementations for the SDK. This better aligns the behavior with the current client spec and removes the need to always nil check any client.
Issues
Changelog Entry Instructions
To add a custom changelog entry, uncomment the section above. Supports:
For more details: custom changelog entries
Reminders
feat:,fix:,ref:,meta:)