Skip to content

fix(javascript): Use platformicons Pi icon for Pi Durable guide - #19931

Merged
andreiborza merged 1 commit into
masterfrom
abo/pi-platformicon
Oct 13, 2026
Merged

andreiborza merged 1 commit into
masterfrom
abo/pi-platformicon

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

DESCRIBE YOUR PR

Bumps platformicons to 9.8.1, which ships the official pi icon in both sizes. The Pi Durable guide now uses it instead of the local src/icons/pi-durable.svg we added in #19873. That local copy is removed.

pi-durable and javascript-pi-durable both point to the new pi icon, so the guide's icon: pi-durable frontmatter works without changes.

IS YOUR CHANGE URGENT?

  • Urgent deadline (GA date, etc.): YYYY-MM-DD
  • Other deadline: YYYY-MM-DD
  • No deadline: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

via Andrei Borza.

--

View Junior Session [Sentry]

Co-Authored-By: Andrei Borza <andrei.borza@sentry.io>
@vercel

vercel Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
develop-docs Ready Ready Preview Oct 13, 2026 9:52am UTC
sentry-docs Ready Ready Preview Oct 13, 2026 9:52am UTC

Request Review

@github-actions github-actions Bot added the Priority: Normal Docs review has no urgent deadline label Oct 13, 2026
@cursor

cursor Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

The plan checks Pi Durable guide loads, missing-icon logs, and client errors. An issue escalates when client errors rise or missing-icon logs appear.

Monitoring in production

Services: sentry-docs, develop-docs.

Mention @change-monitor in a comment to update the plan.

Plan

What changed

The Pi Durable guide now renders the official pi icon from platformicons 9.8.1. The local pi-durable.svg asset is gone. Keys pi-durable and javascript-pi-durable both map to pi.

sentry-docs and develop-docs must both deploy. They share src/components/platformIcon.tsx. The Pi Durable guide itself is only on docs.sentry.io. Catalog match is from the Vercel deploy report workflow and the shared src/ path.

Risk

A missing pi SVG leaves a blank icon. The component logs svg is null and does not throw. A bad platformicons 9.8.1 build can blank other icons on the platform grid and platform selector. A broken image source can throw a client error on those pages. A different SVG size can shift layout on pages that show many icons. develop-docs ships the same component even though it does not host the Pi Durable guide.

Intended effect

The new icon art is not queryable. Use Pi Durable guide page loads as a reachability proxy. absent looks like that counter at zero while other page loads continue.

Signal Baseline Rule Source
docs.page.load with path:*pi-durable* 16 events per 24h Hold near this 24h level. absent if a comparable 24h window is 0 while sitewide docs.page.load continues Sentry org sentry project docs, environment:production, 2026-10-12T09:45:09Z to 2026-10-13T09:45:09Z. Sitewide docs.page.load in that window was 18470

Regression watch

This diff can blank icons or throw on next/image wherever PlatformIcon renders. Watch client errors on both ships. Watch the missing-icon log this component already emits.

Algolia and Kapa Failed to fetch TypeErrors were the bulk of docs TypeErrors in this window. Do not treat those titles as this change.

Signal Baseline Rule Source
Docs production error events 193 events per 24h, 1.0% of 18470 docs.page.load events Hold this 24h rate. Detected if the ratio or the 24h count rises Sentry org sentry project docs, environment:production, 2026-10-12T09:45:09Z to 2026-10-13T09:45:09Z
svg is null logs 0 events per 24h Stay at zero Sentry org sentry project docs, logs message:"*svg is null*", 2026-10-12T09:45:09Z to 2026-10-13T09:45:09Z
PlatformIcon or next/image errors 0 events per 24h Stay at zero Sentry org sentry project docs, environment:production, message match on PlatformIcon, platformicons, or next/image, 2026-10-12T09:45:09Z to 2026-10-13T09:45:09Z
develop-docs production error events 60 events per 24h Hold this 24h count. This row has no measured page-load denominator Sentry org sentry project develop-docs, environment:production, 2026-10-12T09:45:09Z to 2026-10-13T09:45:09Z

Not observable

Which SVG the browser painted is not in telemetry. Pageload CLS timed out, so layout shift from the new icon size is not in this plan. develop-docs page-load volume was not measured.

@andreiborza
andreiborza merged commit 8542d1c into master Oct 13, 2026
29 checks passed
@andreiborza
andreiborza deleted the abo/pi-platformicon branch October 13, 2026 11:09
@cursor

cursor Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Verified in production

  • The Pi Durable guide kept loading after this ship, and missing-icon logs stayed at zero.

This branch was successfully deployed

2 active deployments
Preview – sentry-docs — 6ce1314d Deployed Oct 13, 2026 by vercel[bot]
Preview – develop-docs — 6ce1314d Deployed Oct 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Normal Docs review has no urgent deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants