Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
|
The plan checks errors on the changed guide pages, loads of those pages, and site error volume. An issue escalates when those page errors appear or site errors rise. Services: Mention PlanWhat changedThe NestJS Cron decorator docs now describe auto monitor config from RiskWrong MDX can fail both pages that share this include. A broken code block can fail the shared code tab on those pages. Readers can then miss how to create a monitor from Intended effectThis change is a docs edit. No queryable signal shows the new section is live. Regression watchThis include ships on the NestJS Cron decorator page and the NestJS crons setup page. A render fault would show as errors or a drop in NestJS guide loads.
The 24h p95 may include slow navigations. Escalate when NestJS guide errors leave zero or site errors leave the hourly band. Not observableWhether the new heading is visible on the published pages. Traffic on the sentry-cron-decorator page alone had no traces in this window. Whether the JavaScript SDK ships the 11.5.0 Cron behavior. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
coolguyzone
left a comment
coolguyzone
left a comment
There was a problem hiding this comment.
LGTM! Please address or resolve the review bot comment before merging.
Part of a series adding automatic Crons monitoring for the most-used job schedulers in each SDK. Check-ins for a monitor that doesn't exist yet are dropped, so today each monitor has to be created by hand with its schedule copied from the code. Sending the job's schedule as the monitor config lets Sentry create the monitor and keep it in sync. `@SentryCron` now sends the schedule and time zone of the method's `@Cron()` decorator with its check-ins, so Sentry creates the monitor on the first run. It's on by default; pass `fromCronDecorator: false` to send no config. A config with its own `schedule` is used as is. Monitors created this way are billed, and their schedule and time zone are overwritten from `@Cron()` on each check-in. ```ts @Cron('0 30 9 * * 1-5', { timeZone: 'Europe/Vienna' }) @SentryCron('daily-report', { checkinMargin: 2 }) async dailyReport() {} ``` Without a `timeZone`, the server's local time zone is sent. Schedules Sentry would read differently from `@nestjs/schedule` (sub-minute, numeric months, some day-field combinations, fixed UTC offsets) check in without a config. Docs: getsentry/sentry-docs#19782 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: isaacs <i@izs.me>
DESCRIBE YOUR PR
Documents that
@SentryCronnow sends the schedule and time zone of@Cronon the same method, so check-ins create the monitor. Covers the server time zone default, which schedules send no config, and thefromCronDecorator: falseopt-out.SDK change: getsentry/sentry-javascript#25013. Merge after it ships; the page marks it as available since 11.5.0, which assumes it lands in the next minor.
IS YOUR CHANGE URGENT?
PRE-MERGE CHECKLIST