Skip to content

ref(attributes): Scrub S3 object keys by default - #713

Merged
pabloDeputter merged 3 commits into
mainfrom
pablo/aws-s3-scrubbing
Oct 20, 2026
Merged

pabloDeputter merged 3 commits into
mainfrom
pablo/aws-s3-scrubbing

Conversation

@pabloDeputter

@pabloDeputter pabloDeputter commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Description

Change scrubbing from manual to auto on aws.s3.key, aws.s3.copy_source, and aws.s3.delete. Keys can contain personal data, e.g. customer/alex@example.com/invoice.pdf; default scrubber should be applied as is done on url.full and file.path for example.

(will be rebased and merged after #711 since both change aws.s3.delete)

Change scrubbing from manual to auto on `aws.s3.key`, `aws.s3.copy_source`, and `aws.s3.delete`. Keys  can contain personal data, e.g. "customer/alex@example.com/invoice.pdf"; default scrubber should be applied as is done on `url.full` for example.
@vercel

vercel Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sentry-conventions Ready Ready Preview Oct 20, 2026 8:04am UTC

Request Review

@pabloDeputter

Copy link
Copy Markdown
Member Author

If this is added, this should probably also be done on cloudflare.r2.request.key since both are object storage and keys.

@pabloDeputter
pabloDeputter marked this pull request as ready for review October 13, 2026 16:30
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add message_origin as a sentry.link.type value by JPeer264 in #724
  • Add aws.lambda.resource_mapping.id attribute by pabloDeputter in #710
  • Add object to the sentry.category values by pabloDeputter in #721
  • Add http.request.duration by loewenheim in #697

Other

  • (names) Add queue.publish/create/receive/process/settle to messaging span names by pabloDeputter in #705
  • (ops) Add object.copy op by pabloDeputter in #706
  • Add view.render op by alexander-alderman-webb in #699

Bug Fixes 🐛

  • (attributes) Apply consistent scrubbing across deprecations by mjq in #692

Documentation 📚

  • Clarify cache.ttl for 0, no expiry, and reads by s1gr1d in #725

Internal Changes 🔧

  • (attributes) Scrub S3 object keys by default by pabloDeputter in #713
  • (repo) Update CODEOWNERS to include @giortzisg by Lms24 in #708
  • Deprecate gen_ai.responses in favor of gen_ai.chat by alexander-alderman-webb in #703
  • Add deprecated messaging ops set by the Python SDK by alexander-alderman-webb in #693
  • Add view.response.render op, deprecated in favor of view.render by alexander-alderman-webb in #700
  • Add event.django op, deprecated in favor of function by alexander-alderman-webb in #698

🤖 This preview updates automatically when you update the PR.

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me!

@Lms24

Lms24 commented Oct 14, 2026

Copy link
Copy Markdown
Member

please give this 2-3 days before merging for others to take a look, thanks!

@pabloDeputter
pabloDeputter merged commit 8147bc1 into main Oct 20, 2026
18 checks passed
@pabloDeputter
pabloDeputter deleted the pablo/aws-s3-scrubbing branch October 20, 2026 08:07

This branch was successfully deployed

1 active deployment
Preview — b6a84270 Deployed Oct 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants