Add support for materialized-ops workflow - #243
Open
BojanOro wants to merge 1 commit into
Open
Conversation
Comment on lines
+12
to
+16
| && materialized-ops-set-image \ | ||
| --service="chartcuterie" \ | ||
| --label-selector="${LABEL_SELECTOR}" \ | ||
| --container-name="chartcuterie" \ | ||
| --image="${IMAGE}" |
There was a problem hiding this comment.
Bug: The materialized-ops-set-image command runs unconditionally in a shared script, causing it to execute during canary deployments, which may be unintended.
Severity: MEDIUM
Suggested Fix
Add conditional logic to deploy.sh to ensure materialized-ops-set-image only executes during the primary deployment. This can be done by checking an environment variable that distinguishes between canary and primary stages before invoking the command.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: gocd/templates/bash/deploy.sh#L12-L16
Potential issue: The `deploy.sh` script is shared between `deploy-canary` and
`deploy-primary` stages. The newly added `materialized-ops-set-image` command runs
unconditionally in both. This causes it to execute during canary deployments with a
canary-specific `LABEL_SELECTOR` (`'service=chartcuterie,env=canary'`), which may be
unintended. The expected behavior is often for such tracking commands to run only during
the primary deployment. This could lead to incorrect or duplicate deployment records in
the `materialized-ops` system, potentially complicating deployment monitoring and
rollbacks.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for writing git commits to
materialized-opsduring its code deployment pipeline.Re: https://github.com/getsentry/devinfra-deployment-service/pull/907