fix(render): disable return before full canvas paint - #237
Merged
Conversation
nikkikapadia
marked this pull request as ready for review
July 2, 2026 18:31
nikkikapadia
commented
Jul 2, 2026
| // https://echarts.apache.org/en/option.html#series-heatmap.progressive | ||
| function disableProgressive(series: SeriesOption): SeriesOption { | ||
| return {...series, progressive: 0, progressiveThreshold: Infinity}; | ||
| return {...series, progressive: 0, animation: false}; |
Member
Author
There was a problem hiding this comment.
putting animation: false in here because it was suggest in this issue thread
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using some undocumented e-charts hack that will basically invalidate the paint timer so that the canvas returns only when the full chart is painted and not just after the timer goes off. We were getting this error
TypeError: Cannot read properties of null (reading 'layerStack')that seemed to be thrown because of the timeout.Some notes about this
getTime()api option is that it was added around 2 months ago so seems fairly recent but doesn't seem like it was added to fix a bug. My gut says it will probably stay but here's the links to those commits and PRs anyways:Done with claude's help so feel free to suggest other solutions