Skip to content

Fix shell injection vulnerability in GitHub Actions workflow #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fix-it-felix-sentry wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix shell injection vulnerability in GitHub Actions workflow #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/release-ghcr-version-tag.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,18 @@ jobs:
password: ${{ secrets.GITHUB_TOKEN }}

- name: Tag release version
env:
REF_NAME: ${{ github.ref_name }}
GITHUB_SHA: ${{ github.sha }}

@cursor cursor Bot May 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reserved GITHUB_SHA variable cannot be overridden in env

Low Severity

GITHUB_SHA is a reserved default environment variable in GitHub Actions, and GitHub's docs state that GITHUB_* variables cannot be overwritten. The env: GITHUB_SHA declaration may be silently ignored, with $GITHUB_SHA in the run block resolving to the built-in default instead. This happens to have the same value for release events, so no breakage occurs today, but the override is misleading. A non-reserved name like COMMIT_SHA would be more reliable and accurate.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b21b06a. Configure here.

run: |
docker buildx imagetools create --tag \
ghcr.io/getsentry/chartcuterie:${{ github.ref_name }} \
ghcr.io/getsentry/chartcuterie:${{ github.sha }}
ghcr.io/getsentry/chartcuterie:"$REF_NAME" \
ghcr.io/getsentry/chartcuterie:"$GITHUB_SHA"

- name: Tag latest version
env:
GITHUB_SHA: ${{ github.sha }}
run: |
docker buildx imagetools create --tag \
ghcr.io/getsentry/chartcuterie:latest \
ghcr.io/getsentry/chartcuterie:${{ github.sha }}
ghcr.io/getsentry/chartcuterie:"$GITHUB_SHA"
Loading