Skip to content

ref(build): release Docker image through Craft #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aldy505 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ref(build): release Docker image through Craft #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions .craft.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,28 @@
github:
owner: getsentry
repo: chartcuterie

changelogPolicy: auto

statusProvider:
name: github
minVersion: "2.19.0"
changelog:
policy: auto
artifactProvider:
name: none
statusProvider:
name: github

config:
contexts:
- 'build-docker-image-arm64'
- 'build-docker-image-amd64'
- 'assemble-chartcuterie-image'
targets:
- id: release
name: docker
source: us-docker.pkg.dev/sentryio/chartcuterie-mr/image
target: getsentry/chartcuterie
source: ghcr.io/getsentry/chartcuterie
target: ghcr.io/getsentry/chartcuterie
Comment on lines 14 to +17

@sentry sentry Bot Mar 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The release process will fail because it looks for a CalVer-tagged Docker image, but the CI workflow only creates images tagged with the commit SHA and nightly.
Severity: CRITICAL

Suggested Fix

Before the Craft release step runs, add a new step to the release workflow. This step should pull the image tagged with the commit SHA (or nightly) and re-tag it with the new CalVer version that the release will use. Then, push this newly tagged image to GHCR.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .craft.yml#L14-L17

Potential issue: The release process configured in `.craft.yml` uses a CalVer versioning
policy, which means it will attempt to pull a Docker image tagged with a version like
`24.4.1`. However, the CI build process only tags images with the commit SHA and
`nightly`. Because no image is ever tagged with the corresponding CalVer version, the
Craft release workflow will fail when it cannot find the source image it expects. This
will block all future releases.

Did we get this right? 👍 / 👎 to inform future reviews.

- id: latest
name: docker
source: us-docker.pkg.dev/sentryio/chartcuterie-mr/image
target: getsentry/chartcuterie
source: ghcr.io/getsentry/chartcuterie
target: ghcr.io/getsentry/chartcuterie
targetFormat: "{{{target}}}:latest"
- name: npm
access: public
- name: github

versioning:
policy: calver
28 changes: 0 additions & 28 deletions .github/workflows/release-ghcr-version-tag.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
fetch-depth: 0

- name: Prepare release
uses: getsentry/craft@c6e2f04939b6ee67030588afbb5af76b127d8203 # v2
uses: getsentry/craft@v2 # Not pinned to avoid churn in Craft's releases
env:
GITHUB_TOKEN: ${{ steps.token.outputs.token }}
with:
Expand Down
Loading