Repository navigation
feat(runtime): popcraft.setPanelIcon for a plugin's sidebar panel icon - #12
Merged
Merged
Conversation
A plugin with a sidebar panel can change the panel's rail icon while it runs, in the rail's colour or its own (e.g. a connector showing it is connected). The editor resets it when the plugin stops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
popcraft.setPanelIcon({ panel?, icon?, color? })to the plugin runtime andPopCraftPanelIconOptionsto the types. A plugin with a sidebar panel (contributes.panels) can swap its rail icon while it runs, as a mask in the rail's colour (default) or in its own colours (color: true);icon: nullgoes back to the manifest icon. The editor resets it when the plugin stops.Host side: getpopcraft/popcraft-app (the
setPanelIconcommand +contributes.panels[].autostart). First user: the Nihmbus plugin, whose rail icon is an outline when disconnected and the coloured logo when connected.pnpm buildandpnpm typecheckpass.