Polish: log_format validation, clearer URL errors, status-drop logging

[CryptoFewka]

What

The Low/minor findings from the full-main review (polish; no behavior-critical bugs).

• config: reject an unknown KEYSYNC_LOG_FORMAT. The --log-format flag is enum-restricted by click, but the env-var path wasn't, so KEYSYNC_LOG_FORMAT=yaml silently rendered console output. Now a field_validator fails config (EXIT_CONFIG) for anything but console/json.
• config: clearer schemeless-URL error. A bare host like console.getoptimum.io (no scheme) was rejected with the generic "must use https"; it now reports the missing scheme specifically.
• beacon: log known-but-excluded validators. A validator the beacon knows but whose status is outside the owned set (e.g. withdrawal_done) was filtered out with zero diagnostic, so a real exit dropping out of the desired set was invisible. A shared _included helper now logs the count + statuses at info level. (Behavior unchanged; existing status-filter test still passes.)

Intentionally not included (noted as deferred in the review): _read_pubkeys deferring format validation to the beacon (intended design), the theoretical operator_id == 0 falsy case (real operator ids aren't falsy), the internal-only logging.configure(level=...) strictness (no user path sets it), and the dead min_length guard on URL fields (harmless).

Tests

• test_unknown_log_format_rejected, test_schemeless_url_rejected_with_scheme_message.
• pytest: 88 passed; ruff + mypy: clean.

Written with Claude Code

Summary by CodeRabbit

• Bug Fixes

  • Improved validator filtering visibility by logging when excluded items are dropped.
  • Added stricter startup validation for API URLs without a scheme, with clearer error messages.
  • Rejected invalid log format values during configuration loading, including environment-based settings.

• Tests

  • Added coverage for scheme-less URL rejection and invalid log format validation.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: getoptimum/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4e463468-3849-4190-be45-0b12408524ca

📥 Commits

Reviewing files that changed from the base of the PR and between 9e7993b and b393c65.

📒 Files selected for processing (3)

• src/optimum_keysync/beacon_client.py
• src/optimum_keysync/config.py
• tests/test_config.py

---

📝 Walkthrough

Walkthrough

BeaconClient now uses a shared helper to filter included validator statuses and logs excluded candidates. Config loading now rejects API URLs without a scheme and validates log_format values against console and json. Tests cover both config validation cases.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• getoptimum/optimum-customer-key-import#7: also changes resolve_indices and status filtering in BeaconClient.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands.}