Created a new theme (mako and jinja) based on bulma#3895
Closed
arunpersaud wants to merge 3 commits into
Closed
Conversation
Member
|
New themes are not allowed in the main repo. You can contribute to the themes repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
This adds a bulma theme for both template engines. I created a
nikola init -qd mytest, changed the conf.py to the new theme (bulma or bulma-jinja), build the page and served it. I adjusted the css so that somewhat matches the old schemes. If there are other good tests that one could use, I'm happy to run those too.I'm not a designer ;) so there probably could be more improvements to be made, but I think it's nice to have a more modern CSS framework available. Happy to modify as needed and perhaps further changes can come in future PRs?
Also, it seems that html5shiv got removed, but was still present in the npm_asset directory, so this PR also removes this.