Fix 3810 import sizes false#3844
Open
Ayudh-M wants to merge 5 commits into
Open
Conversation
|
Can confirm that the fix is working. |
|
I reproduced the failing lint job locally. The CI logs have expired, but the equivalent commands show the issue is one whitespace-only line: Minimal patch: diff --git a/nikola/plugins/command/import_wordpress.py b/nikola/plugins/command/import_wordpress.py
@@
meta["width"] = int(size_info[width_key])
meta["height"] = int(size_info[height_key])
# ------------------------------------------------------------------
-
+
path = urlparse(url).pathVerified locally: python -m flake8 nikola/ tests/ --count --show-source
python -m pydocstyle --count --match-dir='(?!^\.)(?!data).*' nikola/
git diff --checkBoth lint commands return |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
fix-3810-import-sizes-false.AUTHORS.txtandCHANGES.txt.flake8 nikola testsandpydocstyle— no new warnings.nikola init -qd demosite && nikola build) and reproduced the WordPress import before/after the fix.Description — fix #3810
nikola import_wordpresscrashed withTypeError: 'bool' object is not subscriptablewhen a WordPress export contained
"sizes" => falsein_wp_attachment_metadata(WordPress ≥ 6 writes this when an image has no alternate renditions).This patch:
metadata[b'sizes']flake8/pydocstyleNo functional change beyond preventing the crash.
Testing
nikola import_wordpress furious-gamingde.WordPress.2025-01-12.xml --no-downloads --output new_sitebefore patch