Add bootstrap 5 and bootblog5 themes in mako and jinja#3840
Open
dacog wants to merge 9 commits into
Open
Conversation
|
Thanks for the new themes, I've tried something out but they are not working. Just found that some file was commit as symlink that link to you local path. Check these files:
|
Author
|
Hi @X1aomu , sorry for the late response. All those files are mentioned in As far as I understood, that is the proper way to add those files. Maybe someone else can provide some feedback on this matter? I can modify this and add the copies of the files, but I re-checked and the bootstrap4 themes also have the symlinks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
I added the Bootstrap 5 and Bootblog5 themes for Bootstrap 5.3.
I did the following:
I could not find
baguetteBox-links-with-images-only.patchto patch baguetteBox. Is this still required?I tested by installing my modified nikola locally (
pip install -e .) and created a new demo site.Then I used a demo site (
nikola init -qd) and run anikola build -afor each theme.I then created a new subtheme
nikola subtheme -p bootstrap5 -n daco -s journaland checked that it was ok.I think that was in summary.
Somewhere I read that nikola uses the jinjify.py to create the jinja versions, that is why I created the mako versions first and updated the scripts so that they worked with the new versions.
Here is the home of the demo for each new theme as examples.
I hope this helps. Let me know if I need to change anything.
Best,
Diego