Enhancements for generating sitemaps#2090
Open
msnoigrs wants to merge 2 commits into
Open
Conversation
msnoigrs
force-pushed
the
robots_exclusions
branch
from
September 16, 2015 03:29
3db2cce to
1dd0178
Compare
Contributor
|
Need to output a warning when using copied resource robots.txt and 1) it doesn’t contain "Sitemap: /sitemapindex.xml" or 2) doesn’t contain every entry in ROBOTS_EXCLUSIONS. |
Contributor
Author
|
A warning is already outputed in nikola/plugins/task/robots.py.
|
Contributor
Author
|
It works for me. on both python2 and python3. |
msnoigrs
force-pushed
the
robots_exclusions
branch
from
September 17, 2015 12:39
1dd0178 to
b91024f
Compare
If the robots.txt file already exist, read it and ignore ROBOTS_EXCLUSIONS.
msnoigrs
force-pushed
the
robots_exclusions
branch
from
September 18, 2015 13:15
b91024f to
cac59c7
Compare
Contributor
Author
|
I wrote the simple code. |
Member
|
I am not familiar with this code, but this PR looks ok for me ad it has sat here for way too long... any opinions @Kwpolska ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains three enhancements of generating sitemaps.