Skip to content

fix(ui): dark-mode modals use the app's blue-tinted background, not flat black #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juandavidr7 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): dark-mode modals use the app's blue-tinted background, not flat black #963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/styles/futuristic.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ body::before {
}

/* Modal surface (`bg-dialog`). SOLID in both themes (the `dialog` token:
neutral.800 dark, white light) — no glass, no backdrop-filter. Modals sit
cool.gutter-dark dark — the app-background blue-tinted tone — white
light) — no glass, no backdrop-filter. Modals sit
over arbitrary content and must never bleed it through; WebView2 in the
desktop shell doesn't reliably composite backdrop-filter anyway (the dark
"New agent" modal bled the Settings page through, and light washed out
Expand Down
2 changes: 1 addition & 1 deletion packages/design-tokens/test/legacy-resolved.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"ht-card": "rgba(40, 40, 40, 0.5)",
"ht-card-hover": "rgba(50, 50, 52, 0.58)",
"ht-card-text": "#e5e5e5",
"ht-dialog": "#1e1e1e",
"ht-dialog": "#141416",
"ht-card-solid": "#2c2c2b",
"ht-danger": "#ef4444",
"ht-danger-text": "#ffffff",
Expand Down
2 changes: 1 addition & 1 deletion packages/design-tokens/tokens/semantic/color.dark.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"card-text": { "$value": "{color.neutral.150}" },
"popover": { "$value": "{color.neutral.800}" },
"popover-text": { "$value": "{color.neutral.150}" },
"dialog": { "$value": "{color.neutral.800}" },
"dialog": { "$value": "{color.cool.gutter-dark}" },
"ink": { "$value": "{color.neutral.150}" },
"ink-muted": { "$value": "{color.neutral.450}" },
"action": { "$value": "{color.neutral.150}" },
Expand Down
6 changes: 3 additions & 3 deletions ui/core/src/components/dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ function DialogContent({
data-slot="dialog-content"
className={cn(
// Modal surface token `bg-dialog`: SOLID in both modes (white in
// light, neutral.800 in dark) — modals sit over arbitrary content
// and must never bleed it through. Not `bg-card` (glass in both
// modes).
// light, cool.gutter-dark in dark — the app-background blue-tinted
// tone) — modals sit over arbitrary content and must never bleed it
// through. Not `bg-card` (glass in both modes).
"fixed top-[50%] left-[50%] z-50 grid w-full max-w-[calc(100%-2rem)] translate-x-[-50%] translate-y-[-50%] gap-5 rounded-2xl border border-line/50 bg-dialog p-6 shadow-[0_4px_4px_rgba(0,0,0,0.04),0_4px_80px_8px_rgba(0,0,0,0.04),0_0_1px_rgba(0,0,0,0.62)] dark:shadow-[0_4px_4px_rgba(0,0,0,0.1),0_4px_80px_8px_rgba(0,0,0,0.2),0_0_1px_rgba(255,255,255,0.1)] duration-200 outline-none data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=closed]:zoom-out-95 data-[state=open]:animate-in data-[state=open]:fade-in-0 data-[state=open]:zoom-in-95 sm:max-w-lg",
className,
)}
Expand Down
Loading