Checkboxes fix - #472
Open
NicoHood wants to merge 2 commits into
Open
Conversation
NicoHood
commented
Jan 9, 2021
NicoHood
commented
Contributor
- Fix Multiple issues with checkboxes #471 checkboxes state when all boxes are empty
- Fixed checkboxes translation in email template
NicoHood
force-pushed
the
checkboxes_fix
branch
from
January 9, 2021 09:22
0fbb624 to
2d3ca9b
Compare
mahagr
reviewed
Jan 11, 2021
mahagr
reviewed
Jan 11, 2021
mahagr
referenced
this pull request
Jan 11, 2021
rhukster
reviewed
Jan 11, 2021
Contributor
Author
|
Would you mind merging this? |
Member
|
I will look at this one again now I've released Form. |
NicoHood
force-pushed
the
checkboxes_fix
branch
from
February 11, 2021 17:49
bab539e to
c107f26
Compare
Contributor
Author
|
I have rebased my changes, simply removing the translation fix, as it was merged in #494 |
Member
|
I won't accept this fix as it won't work in admin (it doesn't use form plugin, just the field), but I have an idea how to fix this. |
Contributor
Author
|
Any progress on this issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.