Add missing URI attributes to HtmlSanitizer - #940
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates HtmlReference::URI_ATTRIBUTES, which is consumed by HtmlSanitizer, to recognize additional HTML attributes as URI-bearing so they receive URI sanitization (scheme filtering / external URI handling) consistently.
Changes:
- Expanded
HtmlReference::URI_ATTRIBUTESto include additional URI-capable HTML attributes (e.g.,archive,cite,classid,codebase,data,formaction,manifest,poster,usemap). - Reordered the
URI_ATTRIBUTESlist while keeping existing entries likesrc,href, andping.
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the list of URI attributes in the
HtmlReferenceclass to better align with HTML standards and improve security and compatibility. The main change is the expansion of theURI_ATTRIBUTESarray to include additional attributes that can contain URIs.HTML Sanitization Improvements:
URI_ATTRIBUTESarray inHtmlReferenceto include more HTML attributes that may contain URIs, such asarchive,background,cite,classid,codebase,data,formaction,longdesc,manifest,poster, andusemap(formwork/src/Sanitizer/Reference/HtmlReference.php).