#176 - Upgrade to compileSdk/targetSdk 36 and bump Compose/AndroidX deps - #177
Merged
Conversation
Required by Google's SDK 36 policy. AGP bumped to 8.10.0 (minimum needed for compileSdk 36, stays on the Gradle 8.x/AGP 8.x track rather than migrating to AGP 9). Verified edge-to-edge and predictive back both work correctly on an Android 16 emulator. Also refreshed the Compose BOM and related AndroidX libraries (activity, lifecycle, navigation, hilt, core, work, datastore, splashscreen, material, accompanist) to their latest versions compatible with AGP 8.x, and dropped the unused accompanist navigation-material dependency.
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the Android build to comply with Google’s SDK 36 policy by raising compile/target SDK to 36, updating AGP, and refreshing Compose/AndroidX dependency versions while removing an unused Accompanist dependency.
Changes:
- Bump compileSdk/targetSdk to 36 and update AGP/Kotlin/AndroidX/Compose-related versions via the version catalog.
- Remove explicit
composeOptions.kotlinCompilerExtensionVersionin favor of the Compose compiler Gradle plugin. - Drop the unused
accompanist-navigation-materialdependency and adjustMainActivity’sonNewIntentsignature for newer SDK nullability.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gradle/libs.versions.toml | Updates SDK levels and refreshes Gradle/dependency versions; removes version pins now expected to be managed by BOMs/plugins. |
| android/app/src/main/java/app/eduroam/geteduroam/MainActivity.kt | Updates onNewIntent to match new SDK nullability expectations. |
| android/app/build.gradle.kts | Removes old Compose compiler extension pin and drops an unused Accompanist dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Both call sites (onCreate's intent property, onNewIntent's now non-null parameter) always pass a non-null Intent, so the nullable type was just dead weight forcing pointless safe-calls and letting a null slip unchecked into NavController.handleDeepLink(). Addresses PR review feedback from Copilot on #177.
dzolnai
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required by Google's SDK 36 policy. AGP bumped to 8.10.0 (minimum needed for compileSdk 36, stays on the Gradle 8.x/AGP 8.x track rather than migrating to AGP 9). Verified edge-to-edge and predictive back both work correctly on an Android 16 emulator.
Also refreshed the Compose BOM and related AndroidX libraries (activity, lifecycle, navigation, hilt, core, work, datastore, splashscreen, material, accompanist) to their latest versions compatible with AGP 8.x, and dropped the unused accompanist navigation-material dependency.