Downgrade strictness on Persister parser - #175
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR relaxes XML parsing strictness in AndroidConfigParser so the app can accept .eap-config files that contain additional high-level fields the Android app does not consume (e.g., the Fingerprint field referenced in the linked Windows-app requirement).
Changes:
- Make Simple XML
Persister.read(...)non-strict (strict = false) when parsingEAPIdentityProviderListfrom the.eap-configpayload.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downgrades Persister strictness to handle situations where the .eap-config contains high level fields we do not need. Other parts of parsing were already set to non-strict.
Based on Fingerprint requirement in geteduroam/windows-app#70 - Checked with Surf, app does not require this fingerprint field now or in the future.