#170 - Switch to AnyBrowserMatcher to support bigger list of browsers - #172
Merged
Conversation
…, add extra logging
dzolnai
approved these changes
Jul 3, 2026
dzolnai
left a comment
dzolnai
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, I'm a bit unsure if the custom tabs filter is good with the anybrowsermatcher, so I asked copilot for a second set of eyes
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Android OAuth/AppAuth integration to remove the restrictive “approved browser” allow-list so users can authenticate with a wider range of Custom Tabs-capable browsers (e.g., Edge, DuckDuckGo), and improves observability around the Custom Tabs vs WebView fallback path.
Changes:
- Replaces the AppAuth
BrowserAllowListmatchers withAnyBrowserMatcherto broaden browser compatibility. - Adds Timber logging around authorization intent creation, selected browser package, Custom Tabs package discovery, and WebView fallback triggers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| android/app/src/main/java/app/eduroam/geteduroam/oauth/OAuthViewModel.kt | Adds diagnostic Timber logs for browser selection, Custom Tabs discovery, and fallback decisions during OAuth initialization. |
| android/app/src/main/java/app/eduroam/geteduroam/di/assist/AuthenticationAssistant.kt | Switches AppAuth browser matcher configuration to AnyBrowserMatcher to remove the previous browser restriction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+97
to
+100
| Timber.d( | ||
| "Authorization intent built, browser package selected by AppAuth: %s", | ||
| authorizationIntent.`package` ?: authorizationIntent.component?.packageName ?: "unknown" | ||
| ) |
Comment on lines
+110
to
+113
| Timber.i( | ||
| e, | ||
| "No browser allowed by AppAuth's BrowserAllowList could be resolved, triggering WebView fallback" | ||
| ) |
Comment on lines
+162
to
+166
| Timber.d( | ||
| "Custom Tabs capable packages found: %s", | ||
| packagesSupportingCustomTabs.joinToString { it.activityInfo.packageName } | ||
| .ifEmpty { "none" } | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes old restriction of approved browsers on OAuth as this was preventing users with alternative browsers such as DuckDuckGo and Microsoft Edge from using the application.
Tested to work with a variety of different browsers as long as these support CustomTabs. If not, we fall back to the WebView implementation. This fallback does not work if the IdP itself blocks Webviews from rendering the login page, but this is out of our hands.