Skip to content

Do not prompt username/password if already provided - #168

Merged
SanderVeer merged 2 commits into
mainfrom
bugfix/PrefilledCredentials
Jun 19, 2026
Merged

Do not prompt username/password if already provided#168
SanderVeer merged 2 commits into
mainfrom
bugfix/PrefilledCredentials

Conversation

@jornane

@jornane jornane commented Jun 15, 2026

Copy link
Copy Markdown
Member

If a username/password combination is already provided in the ClientSideCredential, do not prompt for a username/password.

<ClientSideCredential>
	<UserName>user@example.com</UserName>
	<Password>Tr0b4d0r</Password>
</ClientSideCredential>

@jornane

jornane commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

This fixes the most pressing problems in #167.

However, it does not handle the case where a UserName was provided but not a Password.

@jornane
jornane force-pushed the bugfix/PrefilledCredentials branch from b416d17 to e5721b8 Compare June 15, 2026 15:20
@SanderVeer

Copy link
Copy Markdown
Collaborator

This fixes the most pressing problems in #167.

However, it does not handle the case where a UserName was provided but not a Password.

Thanks for the head start on this issue Jørn! I made a slight tweak to your code but it should work as intended now.

The issue regarding not pre-filling the username if one is provided, but no password, still stands though. This wasn't part of the original implementation of the app but I'll definitely add it to the list of potential areas of improvement.

@SanderVeer
SanderVeer merged commit 171f9c9 into main Jun 19, 2026
1 check passed
@SanderVeer
SanderVeer deleted the bugfix/PrefilledCredentials branch June 19, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants