Do not prompt username/password if already provided - #168
Merged
Conversation
Member
Author
|
This fixes the most pressing problems in #167. However, it does not handle the case where a UserName was provided but not a Password. |
jornane
force-pushed
the
bugfix/PrefilledCredentials
branch
from
June 15, 2026 15:20
b416d17 to
e5721b8
Compare
Collaborator
Thanks for the head start on this issue Jørn! I made a slight tweak to your code but it should work as intended now. The issue regarding not pre-filling the username if one is provided, but no password, still stands though. This wasn't part of the original implementation of the app but I'll definitely add it to the list of potential areas of improvement. |
dzolnai
approved these changes
Jun 19, 2026
SanderVeer
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a username/password combination is already provided in the ClientSideCredential, do not prompt for a username/password.