Repository navigation
CombinerGroup.establish: found its commits pathless - #115
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 6987d17 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
germ-mark
force-pushed
the
mark/ger-2596-founding-paths
branch
from
September 28, 2026 08:41
08621fd to
9dc57ad
Compare
germ-mark
changed the title
establish creates a one-member group and commits the peer add in the immediately-following commit, so there is no gap for a founding UpdatePath to cover. Both halves are now founded pathless. The RFC9420 committing(includePath:) seam is unchanged for callers wanting a path elsewhere. Co-Authored-By: Claude Code <noreply@anthropic.com>
germ-mark
force-pushed
the
mark/ger-2596-founding-paths
branch
from
September 28, 2026 09:03
9dc57ad to
6987d17
Compare
germ-mark
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CombinerGroup.establishcreates a one-member group and commits the peer add in the immediately-following commit — there is no gap for a foundingUpdatePathto cover, so both halves are now founded pathless. No parameter is added: the convenience constructor simply omits the path, and the RFC9420committing(includePath:)seam is unchanged for callers wanting a path elsewhere.Relative to the released 0.1.6 this changes behavior only (no signature change), so the changeset is
patch.Part of GER-2596.
Tests
establishOmitsBothFoundingPaths— both halves' parent nodes are blank (node count pinned), and the pair still joins and verifies from the Welcome.committingcall back toincludePath: truefails exactly the two blank-parent expectations and nothing else.🤖 Generated with Claude Code