Refine lexicon - #1
Merged
Merged
Conversation
ThisIsMissEm
commented
Jan 22, 2026
ThisIsMissEm
commented
Jan 22, 2026
ThisIsMissEm
commented
Jan 22, 2026
ThisIsMissEm
commented
Jan 22, 2026
ThisIsMissEm
force-pushed
the
feat/refine-lexicon
branch
from
January 22, 2026 22:33
0438730 to
97e3dd0
Compare
ThisIsMissEm
force-pushed
the
feat/refine-lexicon
branch
from
January 22, 2026 22:41
a23f30a to
634f158
Compare
ThisIsMissEm
force-pushed
the
feat/refine-lexicon
branch
13 times, most recently
from
January 22, 2026 23:57
da3db55 to
1a7d747
Compare
🟡 Linting WarningsWarnings:
✅ Incompatible ChangesNo breaking changes were detected. ✅ DNSNo DNS issues detected! |
ThisIsMissEm
force-pushed
the
feat/refine-lexicon
branch
6 times, most recently
from
January 23, 2026 00:55
84f0a28 to
4d443d1
Compare
ThisIsMissEm
force-pushed
the
feat/refine-lexicon
branch
8 times, most recently
from
January 23, 2026 02:37
95bca31 to
ac2ae5e
Compare
Contributor
Author
|
The two "com.germnetwork.declaration: string field with no format or maximum size" lines in the check output above cannot be reproduced on my machine. I think this is a bug in goat, even though I'm running the same version. |
ThisIsMissEm
commented
Jan 23, 2026
ThisIsMissEm
commented
Jan 23, 2026
ThisIsMissEm
commented
Jan 23, 2026
Contributor
|
I'll endorse not enforcing limits on the size cryptographic material (current key, keyPackage fields). The length of the continuity proofs array though - is not meant as a complete log but as a rolling window, so we can pull it in a few orders of magnitude. Modal occupancy should be 1. 100 is a SWAG at an upper bound, so I'm ok with 1000 here. If we run out of capacity, clients should fail gracefully |
ThisIsMissEm
commented
Jan 23, 2026
ThisIsMissEm
commented
Jan 23, 2026
ThisIsMissEm
force-pushed
the
feat/refine-lexicon
branch
from
January 23, 2026 18:33
8c284d8 to
242d259
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should probably also add minLength and maxLength on the byte fields.