Skip to content

Refine lexicon - #1

Merged
ThisIsMissEm merged 8 commits into
mainfrom
feat/refine-lexicon
Jan 23, 2026
Merged

Refine lexicon#1
ThisIsMissEm merged 8 commits into
mainfrom
feat/refine-lexicon

Conversation

@ThisIsMissEm

Copy link
Copy Markdown
Contributor
  • Adds description fields
  • Add maxLength and minLength on string fields

We should probably also add minLength and maxLength on the byte fields.

Comment thread lexicons/com/germnetwork/declaration.json Outdated
Comment thread lexicons/com/germnetwork/declaration.json
Comment thread lexicons/com/germnetwork/declaration.json
Comment thread lexicons/com/germnetwork/declaration.json
@ThisIsMissEm ThisIsMissEm reopened this Jan 22, 2026
@ThisIsMissEm
ThisIsMissEm force-pushed the feat/refine-lexicon branch 13 times, most recently from da3db55 to 1a7d747 Compare January 22, 2026 23:57
@github-actions

github-actions Bot commented Jan 22, 2026

Copy link
Copy Markdown

🟡 Linting Warnings

Warnings:

  • File: lexicons/com/germnetwork/declaration.json
    • com.germnetwork.declaration: string field with no format or maximum size
    • com.germnetwork.declaration: bytes field with no maximum size
    • com.germnetwork.declaration: bytes field with no maximum size
    • com.germnetwork.declaration: bytes field with no maximum size
    • com.germnetwork.declaration: string field with no format or maximum size

✅ Incompatible Changes

No breaking changes were detected.

✅ DNS

No DNS issues detected!

@ThisIsMissEm
ThisIsMissEm force-pushed the feat/refine-lexicon branch 6 times, most recently from 84f0a28 to 4d443d1 Compare January 23, 2026 00:55
@ThisIsMissEm
ThisIsMissEm force-pushed the feat/refine-lexicon branch 8 times, most recently from 95bca31 to ac2ae5e Compare January 23, 2026 02:37
@ThisIsMissEm

Copy link
Copy Markdown
Contributor Author

The two "com.germnetwork.declaration: string field with no format or maximum size" lines in the check output above cannot be reproduced on my machine. I think this is a bug in goat, even though I'm running the same version.

Comment thread lexicons/com/germnetwork/declaration.json Outdated
Comment thread lexicons/com/germnetwork/declaration.json Outdated
Comment thread lexicons/com/germnetwork/declaration.json Outdated
@germ-mark

Copy link
Copy Markdown
Contributor

I'll endorse not enforcing limits on the size cryptographic material (current key, keyPackage fields). The length of the continuity proofs array though - is not meant as a complete log but as a rolling window, so we can pull it in a few orders of magnitude.

Modal occupancy should be 1. 100 is a SWAG at an upper bound, so I'm ok with 1000 here. If we run out of capacity, clients should fail gracefully

Comment thread lexicons/com/germnetwork/declaration.json Outdated
Comment thread lexicons/com/germnetwork/declaration.json Outdated
@ThisIsMissEm
ThisIsMissEm merged commit 5d68cc4 into main Jan 23, 2026
2 checks passed
@ThisIsMissEm
ThisIsMissEm deleted the feat/refine-lexicon branch January 23, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants