Add ImageType.jpeg read capability and magic-byte detection - #42
Merged
Conversation
No writer emits .jpeg yet: senders without a JPEG XL encoder (the App Clip) keep labeling JPEG bytes .jpegXL, because deployed clients fail the entire signed CoreIdentity parse on an unknown discriminant. Consumers classify by bytes via ImageType.detect(from:), not the label. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 28b7337 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
case jpeg = 2toImageType, plusImageType.detect(from:)which classifies image bytes by magic number (JXL codestream, JXL container, JPEG). This is read capability only — no writer emits.jpeg.Senders without a JPEG XL encoder (the App Clip, which drops libjxl to cut binary size) will keep labeling their JPEG bytes
.jpegXL, becauseDescribedImagesits inside the signedCoreIdentityquintuple and decode is fail-closed: an unknown discriminant aborts the entire identity/welcome parse on deployed clients rather than degrading to a card without an image. Landing the reader now means a future release can make the label honest once readers are widely deployed; until then consumers should classify by bytes viadetect(from:)rather than trusting the wire label.🤖 Generated with Claude Code