Repository navigation
Adopt GermConvenienceHTTP after the 0.8.0 target split - #23
Merged
Merged
Conversation
GermConvenience 0.8.0 moved HTTPFetcher and HTTPDataResponse out of the base GermConvenience library into a new GermConvenienceHTTP product. Add that product as a dependency and import it where those types are used, and raise the floor to 0.8.0 since that's the version this package now requires. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 7c58613 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CI needs AtprotoClient's GermConvenienceHTTP fix, which is not yet tagged (only merged... not even that — still an open PR at germ-network/AtprotoClient#53). Revision-pin until it releases. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Drop the revision pin now that AtprotoClient's GermConvenienceHTTP fix is released. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GermConvenience 0.8.0 split
HTTPFetcherandHTTPDataResponseout of the baseGermConveniencelibrary into a newGermConvenienceHTTPproduct.Slingshot.swift/Slingshot+Resolver.swiftimport them from the base library, so this package fails to build against 0.8.0.Adds the
GermConvenienceHTTPproduct dependency and the matching import, and raises the floor tofrom: "0.8.0".No public API change —
swift buildandswift testboth green (verified against the not-yet-merged AtprotoClient companion fix germ-network/AtprotoClient#53, since AtprotoClient also needs this same fix and Microcosm depends on it — once that merges/releases, this resolves cleanly on its own).🤖 Generated with Claude Code