Skip to content

Rev OAuthenticator version #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anna-germ merged 6 commits into from
Mar 5, 2026
Merged

Rev OAuthenticator version #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b2c488d
Use experimental OAuthenticator branch
anna-germ Feb 24, 2026
4d3c430
Get rid of iss param
anna-germ Feb 24, 2026
57ea17d
Prevent autocorrection and autocapitalization in demo app
ThisIsMissEm Mar 2, 2026
fd7eadf
Fix demo app
ThisIsMissEm Mar 2, 2026
5ee7dba
Update OAuthenticator to latest DPoP commit
ThisIsMissEm Mar 2, 2026
367c96a
Rev OAuthenticator version
anna-germ Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ...Demo/ATProtoLite-Demo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions ATProtoLite-Demo/ATProtoLite-Demo/Views/AuthenticatedView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ struct CachedAuthenticatedView: View {
case .entry(let error):
HStack {
TextField("@", text: $storedHandle)
.textInputAutocapitalization(.never)
.autocorrectionDisabled()
Button("Check Handle", action: check)
}
if let error {
Expand Down Expand Up @@ -68,7 +70,10 @@ struct CachedAuthenticatedView: View {
Text("@")
TextField(
"handle.bsky.social",
text: $otherHandle)
text: $otherHandle
)
.textInputAutocapitalization(.never)
.autocorrectionDisabled()
Spacer()
}
Button("Make authed fetch") {
Expand Down Expand Up @@ -113,7 +118,7 @@ struct CachedAuthenticatedView: View {
let metadata = try await ATProtoAuthAPI.getAuthedMetadata(
for: theirDID.fullId,
pdsURL: pdsURL,
authenticator: authenticator.authenticator
authenticator: authenticator
)
blocking = metadata.blockingURI != nil
blocked = metadata.isBlocked
Expand Down Expand Up @@ -144,7 +149,7 @@ struct CachedAuthenticatedView: View {
),
for: myDID.fullId,
pdsURL: pdsURL,
authenticator: authenticator.authenticator
authenticator: authenticator
)
}
}
Expand Down
1 change: 0 additions & 1 deletion ATProtoLite-Demo/ATProtoLite-Demo/Views/LoginView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ struct LoginView: View {
let pdsURL = try URL(string: pds!)!

try await viewModel.getAuthenticator(pdsURL: pdsURL)
.authenticator
.authenticate()
}
self.authenticatingTask = authenticatingTask
Expand Down
1 change: 1 addition & 0 deletions ATProtoLite-Demo/ATProtoLite-Demo/Views/UnauthenticatedView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ struct UnauthenticatedView: View {
Text("@")
TextField("Handle", text: $username)
.textInputAutocapitalization(.never)
.autocorrectionDisabled()
}
.padding()
.background(RoundedRectangle(cornerRadius: 10).stroke(.gray))
Expand Down
14 changes: 7 additions & 7 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ let package = Package(
),
.package(
url: "https://github.com/germ-network/OAuthenticator",
exact: "0.7.2-germ.1"
exact: "0.7.2-germ.2"
),
.package(
url: "https://github.com/germ-network/ATResolve",
Expand Down
3 changes: 0 additions & 3 deletions Sources/ATProtoAnchor/Mocks.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ public struct MockDPoPKeyStore: Sendable {

let payload: any Encodable = {
if let nonce = parameters.nonce,
let authorizationServerIssuer = parameters.issuingServer,
let accessTokenHash = parameters.tokenHash
{
DPoPRequestPayload(
Expand All @@ -37,8 +36,6 @@ public struct MockDPoPKeyStore: Sendable {
expiresAt: Int(
Date.now.timeIntervalSince1970 + 3600),
nonce: nonce,
authorizationServerIssuer:
authorizationServerIssuer,
accessTokenHash: accessTokenHash
)
} else {
Expand Down
4 changes: 0 additions & 4 deletions Sources/ATProtoAnchor/ViewModels/P256DPoPSigner.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ extension P256.Signing.PrivateKey {

let payload: any Encodable = {
if let nonce = parameters.nonce,
let authorizationServerIssuer = parameters
.issuingServer,
let accessTokenHash = parameters.tokenHash
{
DPoPRequestPayload(
Expand All @@ -30,8 +28,6 @@ extension P256.Signing.PrivateKey {
Date.now.timeIntervalSince1970
+ 3600),
nonce: nonce,
authorizationServerIssuer:
authorizationServerIssuer,
accessTokenHash: accessTokenHash
)
} else {
Expand Down
Loading