Force Entrance/Exit Direction Pairs for ER - #474
Draft
snowflav-goob wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this add?
Expands upon the work done in 9003012 to make it work with Dungeons and entrance mixing.
This works by re-categorizing entrance types to have an " Entrance" and " Exit" suffix for the categories where we want that behavior and only letting one map to the other. (When mixing with interiors, entrances and exits can map to interiors, and interiors can map to both.)
By working with the direction type being directly in the cateogry's suffix this meant I could get rid of some of the code designed to help with bipartite categories.
Making it work with mixing also meant having to remove the cheap "mixed categories go into the
ER_GROUP_MIXEDGER group" optimization and making a proper group lookup, which I assume is where most of the performance goes away.Why do you want it to be added?
It makes ER way more fun to me by having the entrances actually make sense. I suppose this could be turned into an
er_direction_pairsoption if people don't want that behavior to be the only oneWas this tested yet?
Generated one game with Dungeon+Gym shuffled and mixed, started in Ecruteak with Squirtbottle to have as many entrances to check, also fuzzed to check that the code at the very least runs
I did not do any testing to see how stable GER is with this but the fuzzing shows that it makes it significantly slower, having roughly 20% timeouts