Skip to content

chore: deny leaks, let fmt indent .rs files - #48

Merged
CommanderStorm merged 1 commit into
georust:mainfrom
nyurik:clippy-indent
Jul 12, 2026
Merged

chore: deny leaks, let fmt indent .rs files#48
CommanderStorm merged 1 commit into
georust:mainfrom
nyurik:clippy-indent

Conversation

@nyurik

@nyurik nyurik commented Jul 12, 2026

Copy link
Copy Markdown
Member
  • I agree to follow the project's code of conduct.
    - [ ] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Copilot AI review requested due to automatic review settings July 12, 2026 17:40
@nyurik
nyurik requested a review from CommanderStorm July 12, 2026 17:41
@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.81%. Comparing base (c1ee931) to head (9374fd8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   73.81%   73.81%           
=======================================
  Files           4        4           
  Lines         317      317           
=======================================
  Hits          234      234           
  Misses         83       83           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens linting to prevent intentional memory leaks via Box::leak / Vec::leak, and adjusts repository-wide formatting policy via .editorconfig.

Changes:

  • Forbid clippy::disallowed_methods and configure it to disallow Box::leak / Vec::leak (std + alloc).
  • Remove most indentation rules from .editorconfig, leaving only YAML indentation configured.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
clippy.toml Adds a disallowed-methods list targeting Box::leak / Vec::leak.
Cargo.toml Sets clippy::disallowed_methods lint level to forbid.
.editorconfig Removes global/Markdown/license/lock indentation rules; keeps YAML at 2 spaces.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .editorconfig
@CommanderStorm
CommanderStorm merged commit 9483ad7 into georust:main Jul 12, 2026
8 checks passed
@nyurik
nyurik deleted the clippy-indent branch July 12, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants