Fix mask labels and lineage GEFF exports - #65
Draft
georgeoshardo wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
uint16.(mask_label, time)detections.GeffMetadata, use consistent spatial units for positions and cell dimensions, and keep sliced exports valid under GEFF track and lineage validation.Why
Sparse instance IDs could be normalized as binary masks, and time-series casts could silently wrap an object label to background. Persistent mother metadata also created repeated division edges. Finally,
track_node_propswas passed as a free keyword that current GEFF silently ignored, while length and width were left in pixels even when positions were converted to micrometres.The legacy
.motherfallback was not restored because the current repository explicitly removed that API and rejects legacy simulation artifacts.Validation
pixi run pytest -q tests/test_renderer_mask_export.py tests/test_lineage_compat.py tests/test_geff_export.py— 18 passedpixi run pytest -q— 74 passedThe only test warning is the existing CPU fallback warning when neither CuPy nor PyTorch is available.