Fix image matching and mask helper correctness - #60
Draft
georgeoshardo wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
lumMatchmean and standard deviation values independent of the number of input imagessfMatchfinite for zero-energy radial bins and replace repeated full-image bin scans with one vectorized bin map plusbincountreductionsWhy
The helpers were losing caller-supplied luminance values, calculating one masked statistic from the wrong quantity, producing NaN/inf for constant images, merging touching instance labels, and truncating fractional weights. The Fourier implementation also repeatedly scanned every pixel once per radial bin.
Validation
pixi run pytest -q tests/test_image_helpers.py tests/test_renderer_mask_export.py— 8 passed, 1 existing CPU-fallback warningpixi run pytest -q— 69 passed, 1 existing CPU-fallback warningsfMatchcomparison on 4×4, 5×7, and 32×48 inputs — maximum absolute difference at most1.421e-1329.7 msbefore and15.1 msafter (about 2× faster)No benchmark test was added.
Deliberately unchanged
SyMBac/metrics.pyis only imported bySyMBac/auto_optimise.pyin this repository. Neither file was changed becauseauto_optimise.pyis scheduled for removal.