Skip to content

refactor #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xmountaintop wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions adversary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@
def win_game(needed_s_samples: int, num_of_s: int, M: int):
if num_of_s < needed_s_samples:
return (False, 0.0)
fail_prob = 0.0
for ki in range(0, needed_s_samples):
fail_prob += nhypergeom.pmf(k=ki, M=M, n=num_of_s, r=1)
fail_prob = sum(nhypergeom.pmf(k=ki, M=M, n=num_of_s, r=1) for ki in range(0, needed_s_samples))

return (True, 1.0 - fail_prob)

Expand All @@ -44,15 +42,6 @@ def win_both_games(M: int, k_dl: int, n1: int, n2: int):

probs = [(k_dl, win_both_games(M, k_dl, n1, n2)) for k_dl in range(n1, M)]

max_prob = float('-inf')
max_k_dl = -1

for k_dl, prob in probs:
if prob is None:
continue

if prob > max_prob:
max_prob = prob
max_k_dl = k_dl
max_prob, max_k_dl = max((prob, k_dl) for k_dl, prob in probs if prob is not None)

print(f"The maximum probability is {max_prob} and it is achieved for k_dl={max_k_dl}")