fix: saturate timer tick payload#68
Merged
Merged
Conversation
geoffjay
approved these changes
May 17, 2026
geoffjay
left a comment
Owner
There was a problem hiding this comment.
Code Review
Summary
Clean fix for timer tick overflow (#39). Saturates u64 tick values at i64::MAX instead of the silent wraparound from as i64, and deduplicates payload-building by extracting create_tick_payload_for.
Issues (blocking)
None.
Suggestions (non-blocking)
None — this is well-scoped and correct.
Approved
LGTM. The saturation behavior is correct, the deduplication eliminates a real maintenance hazard, and the test covers the overflow case.
geoffjay
approved these changes
May 17, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 52.35% 52.45% +0.09%
==========================================
Files 71 71
Lines 6101 6097 -4
==========================================
+ Hits 3194 3198 +4
+ Misses 2907 2899 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
i64::MAXbefore storing them inValue::Integer.u64::MAXtick values.Fixes #39
Validation
Blocked:
cargo test -p nemo-data timerstalled while updating the workspace GPUI git dependency (https://github.com/zed-industries/zed); stopped after retrying to avoid leaving a hanging cargo process.