Change webpack back to only one NODE_ENV case#8
Open
milafrerichs wants to merge 2 commits into
Open
Conversation
revert back to one module.export and only change variables for production. otherwise leave the config as it for the default case (development|test) set DEFAULT_CONTEXT to / for less opinionated version
Member
|
Artifacts are injected twice in the html template: should not be there.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the webpack.config.js to it's original intend. Adding css stuff and changing order of the entry points.
Changes
revert back to one module.export and only change variables for
production. otherwise leave the config as it for the default case
(development|test)
set DEFAULT_CONTEXT to / for less opinionated version