Improve compute function FFI - #113
Draft
paleolimbot wants to merge 6 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
- Coverage 94.53% 93.00% -1.53%
==========================================
Files 25 29 +4
Lines 4132 4418 +286
==========================================
+ Hits 3906 4109 +203
- Misses 226 309 +83 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be able to export:
This should be able to be imported and used as a:
...obviously that needs some testing, but the concepts are intended to line up:
This doesn't handle pre-allocated output (maybe DuckDB, Arrow C++). Most geo functions don't benefit from this anyway (very few fixed-width -> fixed width transformations that are cheap enough that they could reuse the input allocation).