#13430 - Svg editor choosing Line endings does not change anything#72
Merged
Conversation
Zeljko-Predjeskovic
force-pushed
the
fix/13430-line-endings-dont-work
branch
3 times, most recently
from
029d54c to
dbf227e
Compare
gentledepp
reviewed
Jun 26, 2026
gentledepp
left a comment
gentledepp
left a comment
Owner
There was a problem hiding this comment.
Code review of the line-endings fix. The core fix is correct (duplicate start dialog removed, end dialog now uses the end-options array). A few follow-ups inline — several are optional/questions.
Zeljko-Predjeskovic
force-pushed
the
fix/13430-line-endings-dont-work
branch
from
dbf227e to
a41b36e
Compare
Zeljko-Predjeskovic
force-pushed
the
fix/13430-line-endings-dont-work
branch
from
a41b36e to
6895979
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.