TileGenerator stores scale factor of tiles (in relation to original s…#70
Merged
Conversation
…vg dimensions) in dimensions.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TileGenerator.WriteMetadataAsyncnow also writesscaleXandscaleY(in addition towidth/height) intodimensions.json.pyramidW / docSize.Width(and Y analogous) — i.e. how much larger the rendered tile pyramid is than the original SVG document.scaleX = scaleY = 1is written, since the plan coordinate system equals the source pixel grid."R"round-trip formatting againstCultureInfo.InvariantCultureso locales with comma decimal separators don't corrupt the JSON.Why
Consumers of the tile archive (in
iCl.Filler.Avalonia) need this factor to re-mapPlanItemcoordinates between the original SVG coordinate system (in which they are persisted in production) and the higher-resolution tile pyramid. Without these fields the consumer cannot align pins/polygons on tile-rendered plans.Test plan
GenerateTilesFromSvgAsync_WritesScaleFactorsToDimensionsJsonverifies that withtargetWidth = 10 × docSize.Width,scaleX ≈ 10andscaleY ≈ pyramidH/docSize.Heightare written and round-trip throughJsonDocument.GenerateTilesFromSvgAsync_ProducesExpectedZoomLevelsto also assertscaleX/scaleYare present.WriteMetadataAsync, confirmed test fails; restored, confirmed it passes.Compatibility
Older tile archives without
scaleX/scaleYwill fail the strict parse on the consumer side and fall back to SVG/image rendering as before — no regression. The consuming feature is still in development, so backward compatibility of existing pyramids was not a requirement.