Yet another try to fix the crashes

[gensyn]

No description provided.

[gensyn]

@copilot Please fix the tests I broke in this branch.

[Copilot]

Pull request overview

This PR attempts to prevent crashes when changing domains by keeping references to combo-row items alive while clearing the entity combo box, likely to avoid premature destruction/GC issues in the underlying GTK/ListModel objects.

Changes:

• Keep entity combo items referenced in a temporary list during remove_all_items() to prevent crashes.
• Explicitly release the temporary references after clearing the combo.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

@copilot Please fix the tests I broke in this branch.

Fixed in the latest commit. The 5 tests that call on_change_domain with differing old/new domains (triggering the get_n_items path) now configure entity_combo_mock.get_n_items = Mock(return_value=0) so range() receives a proper integer. Production code in base_core.py is untouched.