Fix the contribution type dropdown still being cut off on mobile#906
Conversation
The earlier mobile fix let the type dropdown escape the form shell, but the page wrapper around the submit form still became a scroll container on small screens, so the menu was cut at the wrapper's bottom edge before a type was picked. The wrapper now clips only horizontal bleed, letting the dropdown overlap the content below it in full. ## Implementation Notes - frontend/src/routes/SubmitContribution.svelte: mobile .submit-contribution-route rule changed from overflow-x: hidden to overflow-x: clip (hidden forces computed overflow-y to auto, creating a scroll container that clipped the absolutely-positioned type dropdown at the route wrapper's bottom edge — same gotcha as the shell fix in 8f2a1dc, one ancestor up)
|
Warning Review limit reached
Next review available in: 14 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
PR #904 fixed the mobile clipping of the Submit Contribution type dropdown at the form-shell level, but the dropdown was still being cut off at the bottom edge of the page container. The route wrapper (
.submit-contribution-route) had the sameoverflow-x: hiddenrule in its mobile media query, one ancestor above the shell that #904 fixed.Per the CSS spec,
overflow-x: hiddenforces the computedoverflow-ytoauto, silently turning the wrapper into a scroll container that clips absolutely-positioned descendants. The dropdown escaped the fixed shell only to be clipped by the route wrapper instead.Change
frontend/src/routes/SubmitContribution.svelte: the mobile.submit-contribution-routerule now usesoverflow-x: clipinstead ofoverflow-x: hidden.clipcuts horizontal bleed without capturing vertical overflow, so the dropdown now properly overlaps the page content below it regardless of its parent container's height.This is the same fix pattern documented in
frontend/CLAUDE.mdunder Common Issues & Solutions. After this change, no ancestor between the dropdown and the page scroller clips vertical overflow.Testing
main→ route wrapper → form shell → panel → dropdown): the page scroller is now the only scroll container above the dropdown.