Add support for MacAddress - #24
Open
pedrojreis wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to add an option to also edit the MacAddress.
This is useful for some usecases where the MacAddress is "king" and matters the most, also super useful to prevent to have thousands of sim devices with the exact same Mac :)
Said mac will silce the last 2 characters, starting at 00 and going up to 99 depending on number of processes.
I felt like pushing more than 100 devices in a single instance can worsen performance and felt like it's better to have multiple instances with up to 100 devices if we need to make stress tests.
Help Example
Run Example
GenieACS
Feel free to provide feedback to better improve this feature. Even though it's small it allows for a bigger flexibility - specially under kubernetes :)