Skip to content

docs: remove discord link in main readme - #720

Merged
AngeloDanducci merged 2 commits into
generative-computing:mainfrom
AngeloDanducci:ad-discreadme
Mar 23, 2026
Merged

docs: remove discord link in main readme#720
AngeloDanducci merged 2 commits into
generative-computing:mainfrom
AngeloDanducci:ad-discreadme

Conversation

@AngeloDanducci

@AngeloDanducci AngeloDanducci commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

@AngeloDanducci
AngeloDanducci requested a review from a team as a code owner March 23, 2026 14:50
@github-actions

Copy link
Copy Markdown
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@AngeloDanducci AngeloDanducci added the documentation Improvements or additions to documentation label Mar 23, 2026
@mergify

mergify Bot commented Mar 23, 2026

Copy link
Copy Markdown

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@ajbozarth

Copy link
Copy Markdown
Contributor

We should remove the badge at the top at the same time, probably worth doing a quick search across the repo and make sure its also removed from files like contributors.md

@AngeloDanducci
AngeloDanducci added this pull request to the merge queue Mar 23, 2026
@AngeloDanducci
AngeloDanducci removed this pull request from the merge queue due to a manual request Mar 23, 2026
@planetf1

planetf1 commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Agree with these changes - though would also suggest we all review https://github.com/generative-computing/mellea/pull/688/changes as this was a rewritten readme that didn't make it for the release - it's pending review. It can be merged later (and I'll fix conflicts -- the discord link should have been removed there)

@ajbozarth ajbozarth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got everything I found :)

@AngeloDanducci
AngeloDanducci added this pull request to the merge queue Mar 23, 2026
Merged via the queue into generative-computing:main with commit 1a3a01f Mar 23, 2026
6 checks passed
akihikokuroda pushed a commit to akihikokuroda/mellea that referenced this pull request May 27, 2026
* remove discord link in main readme

* additional discord link removals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants