fix: modifications to granite formatter tests - #703
Merged
Conversation
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
jakelorocco
force-pushed
the
jal/fix-g-fmt-tests
branch
from
March 19, 2026 13:55
1710bdd to
33d40a8
Compare
jakelorocco
marked this pull request as ready for review
March 19, 2026 14:17
Contributor
Author
|
@frreiss please take a look when you get a chance. Low priority. |
frreiss
approved these changes
Mar 25, 2026
frreiss
left a comment
Collaborator
There was a problem hiding this comment.
Looks good generally, one minor issue noted below.
jakelorocco
force-pushed
the
jal/fix-g-fmt-tests
branch
from
March 25, 2026 19:44
33d40a8 to
9a20ca3
Compare
jakelorocco
force-pushed
the
jal/fix-g-fmt-tests
branch
from
March 25, 2026 19:49
9a20ca3 to
323793c
Compare
jakelorocco
enabled auto-merge
March 25, 2026 19:50
akihikokuroda
pushed a commit
to akihikokuroda/mellea
that referenced
this pull request
May 27, 2026
* fix: properly mark generative tests in granite formatter tests * fix: move g-formatter test yaml retrieval to test time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
Added pytest markers for the LLM based tests. Changed when yaml collection is done so that tests don't fail at collection time.
Tested the changes and am able to run the tests even with an unavailable adapter; tests now fail during execution and other tests can run:
Testing