test(telemetry): avoid requiring provider chunk intervals - #1626
Merged
Conversation
A streamed response may contain one provider chunk, in which case no inter-chunk interval exists and the optional time_per_output_chunk histogram is empty. Keep the live Ollama test focused on metrics guaranteed by the request while deterministic plugin tests cover interval recording. Assisted-by: Codex Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
ajbozarth
reviewed
Sep 4, 2026
ajbozarth
left a comment
Contributor
There was a problem hiding this comment.
I'm ok with removing this test assert if you've found it flaky.
Merged
via the queue into
generative-computing:main
with commit Sep 4, 2026
0430e87
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Partly addresses #1566 (test case impact on other code)
Description
The live Ollama telemetry test required
gen_ai.client.operation.time_per_output_chunkto exist for every streamed response. That metric records inter-chunk intervals, so a valid one-chunk response has no interval and leaves the histogram empty. Provider chunk framing is not deterministic, even when the prompt produces several output tokens, so the assertion caused unrelated CI failures.Remove that provider-dependent assertion while retaining the live checks for token usage, request duration, and time to first chunk. Deterministic unit coverage for interval recording remains unchanged. The broader producer-side telemetry correction stays scoped to issue #1566.
Testing
Verified locally:
Attribution
Adding a new component, requirement, sampling strategy, or tool?
If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.
NOTE: Please ensure you have an issue that has been acknowledged by a core contributor and routed you to open a pull request against this repository. Otherwise, please open an issue before continuing with this pull request.