feat: add author-pluggable extension point for provider-specific message fields - #1586
Open
AngeloDanducci wants to merge 1 commit into
Open
feat: add author-pluggable extension point for provider-specific message fields#1586AngeloDanducci wants to merge 1 commit into
AngeloDanducci wants to merge 1 commit into
Conversation
…age fields Signed-off-by: AngeloDanducci <angelo.danducci.ii@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Fixes #1565
Description
Allows author-pluggable fields via
provider_fields.Given the exploration around the original issue, I think this gives us the most extensibility for the least amount of headache.
I chose provider-keyed passthrough instead of widening
format_for_llmas this leaks wire shape into component code and doesn't compose well with images/docs (same issue with a global serializer registry). Open to discussion though if anyone can see reasons to alter the design - ie if we think authoring custom serialization logic itself is of greater benefit/immediate need.Testing
Attribution
Adding a new component, requirement, sampling strategy, or tool?
If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.
NOTE: Please ensure you have an issue that has been acknowledged by a core contributor and routed you to open a pull request against this repository. Otherwise, please open an issue before continuing with this pull request.