fix: agent time out issue#303
Conversation
|
[REVIEW NOTIFIER] This PR requires a review from @yanmxa. Once this PR has been reviewed and has the |
|
/assign @yanmxa |
There was a problem hiding this comment.
Two concerns:
-
Default 60s → 180s weakens an intentionally tight signal.
FirstChunkTimeout = 5malready handles reasoning models thinking before the first token; once streaming, both DeepSeek and Claude extended thinking emit reasoning as chunks, so 60s of silence is usually a real stall. #302 has no repro. Prefer keeping the default and letting operators tune per-provider via the new fields. -
New
StreamFirstChunkTimeout/StreamIdleTimeoutonBuildParamshave no callers — no config/flag sets them. Wire them up in this PR or drop until wired.
Nit: internal/core/agent.go:119 still says default (60s) — stale after this change.
2295b19 to
2dd4f4c
Compare
|
@yanmxa thanks for your comments, it make sense, i'd like to revert the default value changes and will introduce a new setting for streaming timeout |
|
@yanmxa please take a look at again |
Signed-off-by: hchenxa <hchenxa1986@qq.com>
What & why
#302
Type of change
Testing
GOCACHE=/private/tmp/san-go-build-cache go test ./...Checklist
feat:,fix:,docs:, …)git commit -s) — certifies the DCO