feat(admin): annotation filters and sorts on session list#158
Merged
Conversation
WalkthroughSession summaries now include annotation recency and active counts. Admin users can filter annotated sessions, sort by annotation metadata, and see active annotation counts in session rows. ChangesAnnotated session administration
Sequence Diagram(s)sequenceDiagram
participant AdminSessionFilters
participant AdminPanel
participant filterAdminSessions
participant AdminSessionRow
AdminSessionFilters->>AdminPanel: toggle annotatedOnly or choose annotation sort
AdminPanel->>filterAdminSessions: apply annotation filter and sort
filterAdminSessions-->>AdminPanel: return ordered session summaries
AdminPanel->>AdminSessionRow: render session summary
AdminSessionRow-->>AdminPanel: display active annotation count
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Comment |
gelbh
force-pushed
the
feat/admin-annotation-filters
branch
from
July 24, 2026 20:17
35215ab to
24dc16b
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/domain/admin/adminSessionFilters.test.ts`:
- Around line 114-123: Extend the admin session filter tests around
filterAdminSessions to cover lastAnnotation sorting with annotatedOnly disabled,
preserving the existing sort configuration and asserting session IDs in the
order many, few, none so the null lastAnnotationAt case is exercised.
In `@src/routes/AdminPanel.test.tsx`:
- Around line 126-127: Add a behavior-focused route test in AdminPanel.test.tsx
using sessions with both annotated and unannotated values, then click the
Annotated filter and assert only annotated sessions remain along with a visible
positive “N ann” count. Update the related fixtures currently using null/zero
annotation fields so the test exercises the annotation UI filtering and count
paths.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: ff71ac8b-895b-46b1-a2a5-a9dd1ab552cb
📒 Files selected for processing (9)
functions/admin/listActiveSessions.mjssrc/components/admin/AdminSessionFilters.tsxsrc/components/admin/AdminSessionRow.tsxsrc/domain/admin/adminSessionFilters.test.tssrc/domain/admin/adminSessionFilters.tssrc/routes/AdminPanel.test.tsxsrc/routes/AdminPanel.tsxsrc/services/admin/adminSessions.test.tssrc/services/admin/adminSessions.ts
Comment on lines
+114
to
+123
| expect( | ||
| filterAdminSessions(sessions, { | ||
| query: "", | ||
| liveOnly: false, | ||
| annotatedOnly: true, | ||
| mode: "all", | ||
| state: null, | ||
| sort: "lastAnnotation", | ||
| }).map((entry) => entry.sessionId), | ||
| ).toEqual(["many", "few"]); |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Cover lastAnnotation sorting when the timestamp is missing.
annotatedOnly: true removes none before sorting, so the lastAnnotationAt: null branch is untested. Add an unfiltered assertion expecting many, few, then none.
As per path instructions, **/*.test.{ts,tsx} requires edge cases for new logic.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/domain/admin/adminSessionFilters.test.ts` around lines 114 - 123, Extend
the admin session filter tests around filterAdminSessions to cover
lastAnnotation sorting with annotatedOnly disabled, preserving the existing sort
configuration and asserting session IDs in the order many, few, none so the null
lastAnnotationAt case is exercised.
Source: Path instructions
Comment on lines
+126
to
+127
| lastAnnotationAt: null, | ||
| activeAnnotationCount: 0, |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Exercise the annotation UI behavior.
These fixtures only use null/zero annotation values. Add a route test with annotated and unannotated sessions that clicks Annotated and verifies filtering plus a visible positive N ann count.
As per path instructions, **/*.test.{ts,tsx} requires behavior-focused assertions on changed code paths.
Also applies to: 169-170, 228-229, 271-272
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/routes/AdminPanel.test.tsx` around lines 126 - 127, Add a
behavior-focused route test in AdminPanel.test.tsx using sessions with both
annotated and unannotated values, then click the Annotated filter and assert
only annotated sessions remain along with a visible positive “N ann” count.
Update the related fixtures currently using null/zero annotation fields so the
test exercises the annotation UI filtering and count paths.
Source: Path instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lastAnnotationAtandactiveAnnotationCounttolistActiveSessionssummaries.· N ann.Test plan
npm test -- src/domain/admin/adminSessionFilters.test.tsnpm run typecheckSummary by CodeRabbit
New Features
Tests