Skip to content

fix(overpass): align QL timeout with 25s fetch abort#157

Merged
gelbh merged 1 commit into
mainfrom
fix/overpass-timeout-align
Jul 24, 2026
Merged

fix(overpass): align QL timeout with 25s fetch abort#157
gelbh merged 1 commit into
mainfrom
fix/overpass-timeout-align

Conversation

@gelbh

@gelbh gelbh commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • Align landmass/admin/warm Overpass QL [timeout:45] to [timeout:25] so query budget does not exceed the proxy fetch abort.
  • Also align audit landmass/admin queries for consistency.

Test plan

  • npx vitest related on touched geo/overpass sources
  • npm run typecheck

Summary by CodeRabbit

  • Performance Improvements
    • Reduced the maximum wait time for geographic data requests.
    • Improved responsiveness when requests take longer than expected.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3a858917-908c-4cb5-99bf-66c16a09ff72

📥 Commits

Reviewing files that changed from the base of the PR and between ee13c27 and 3134b66.

📒 Files selected for processing (4)
  • functions/session/warmOverpassPreload.mjs
  • src/services/geo/adminDivisionBoundaries.ts
  • src/services/geo/landmassFeatures.ts
  • src/services/overpass/auditQueries.ts

Walkthrough

Overpass query builders for warm-preload, geography, and audits now use a 25-second timeout instead of 45 seconds. Query structure, bounding boxes, output format, and control flow remain unchanged.

Changes

Overpass timeout updates

Layer / File(s) Summary
Update Overpass query timeout headers
functions/session/warmOverpassPreload.mjs, src/services/geo/*.ts, src/services/overpass/auditQueries.ts
Warm-preload, landmass, administrative-division, and audit query templates now emit [timeout:25] instead of [timeout:45].

Estimated code review effort: 1 (Trivial) | ~2 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/overpass-timeout-align
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch fix/overpass-timeout-align

Comment @coderabbitai help to get the list of available commands.

@gelbh
gelbh merged commit e1fe678 into main Jul 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant