Fix TypeScript compilation errors in bots.ts#1
Open
railway-app[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two TypeScript compilation errors in
api/src/routes/bots.tswere blocking the build. On line 70,txline.getOdds()was passedmatchIdtyped asstring | string[](Express'sreq.paramstype), but the method only acceptsstring. On line 109,odds?.homeOdds— typed asnumber | nullper theOddsinterface — was used directly in a<comparison without a null guard, which TypeScript rejects.Solution
Wrapped
matchIdinString()on line 70 to coerce thestring | string[]union to a plain string before passing it togetOdds. On line 109, replacedodds?.homeOddswith(odds?.homeOdds ?? 99)in the ternary comparison, mirroring the same nullish-coalescing pattern already used one line below for thepredictionassignment — a nullhomeOddsnow safely falls back to 99 (a high odds value) so the comparison remains semantically correct.Changes
api/src/routes/bots.tsGenerated by Railway