Disable DNS resolution in ruby when service file is used#727
Open
larskanis wants to merge 1 commit into
Open
Conversation
larskanis
force-pushed
the
respect-service
branch
2 times, most recently
from
8fc911a to
44b9a05
Compare
This is based on @travismiller's idea to disable to disable DNS resolution in case of "service" parameter is used. ged#635 (comment) Since pg-1.3 the DNS resolution is done non-blocking in ruby. But pg-1.3 changed the order parameters are processed from: connection string => service file => environment variable => compiled default to: connection string => PGSERVICE => environment variable => compiled default => explicit "service" This commit changes parameter processing order back to libpq's order. Using blocking IO for DNS resolution in case of "service" parameter seems to be a reasonable tradeoff. Fixes ged#635
larskanis
force-pushed
the
respect-service
branch
from
44b9a05 to
1863398
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on @travismiller's idea to disable to disable DNS resolution in case of "service" parameter is used.
#635 (comment)
Since pg-1.3 the DNS resolution is done non-blocking in ruby. But pg-1.3 changed the order parameters are processed from:
connection string => service file => environment variable => compiled default
to:
connection string => PGSERVICE => environment variable => compiled default => explicit "service"
This commit changes parameter processing order back to libpq's order. Using blocking IO for DNS resolution in case of "service" parameter seems to be a reasonable tradeoff.
Fixes #635